Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Alert): use box-shadow as border-left #532

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

framitdavid
Copy link
Contributor

@framitdavid framitdavid commented Jun 9, 2023

resolves: #531

Should use box-shadow as border-left instead of the border-left property. This is done to have the border on the inside of the box just like it is in Figma.

Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@framitdavid framitdavid merged commit f2e02f0 into main Jun 9, 2023
@framitdavid framitdavid deleted the refactor/useBoxShadowInsteadOfBorder branch June 9, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert adjustments: Update with border inside and spacing-4
2 participants